Add kimera spectacular data provider #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efahnestock
force-pushed
the
add_kimera_spectacular_data_provider
branch
from
d104250 to
215fae4
Compare
efahnestock
force-pushed
the
add_kimera_spectacular_data_provider
branch
from
198f078 to
0513473
Compare
ewfuentes
reviewed
Dec 10, 2024
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.hh
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.hh
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.hh
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.hh
Outdated
Show resolved
Hide resolved
ewfuentes
approved these changes
Dec 10, 2024
Co-authored-by: Erick Fuentes <[email protected]>
…uentes/robot into add_kimera_spectacular_data_provider
…uentes/robot into add_kimera_spectacular_data_provider
ewfuentes
reviewed
Dec 12, 2024
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.cc
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider.hh
Outdated
Show resolved
Hide resolved
experimental/overhead_matching/kimera_spectacular_data_provider_test.cc
Outdated
Show resolved
Hide resolved
| return; | ||
| }; | ||
|
|
||
| auto color_camera_callback = [&bgr_queue](std::unique_ptr<VIO::Frame>&& bgr_frame) -> void { |
There was a problem hiding this comment.
I don't think this needs to be an r-value ref: https://stackoverflow.com/questions/37935393/pass-by-value-vs-pass-by-rvalue-reference
experimental/overhead_matching/kimera_spectacular_data_provider_test.cc
Outdated
Show resolved
Hide resolved
…uentes/robot into add_kimera_spectacular_data_provider
ewfuentes
approved these changes
Dec 17, 2024
| @@ -29,10 +20,9 @@ std::ostream &operator<<(std::ostream &out, const time::RobotTimestamp &t) { | |||
| return out; | |||
| } | |||
|
|
|||
| TEST(SpectacularLogTest, happy_case) { | |||
| TEST(SpectacularLogTest, DISABLED_happy_case) { | |||
There was a problem hiding this comment.
I think we can re-enable this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.